Feature: Internal driver plugin system #3693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase e.g., |
unsuman
force-pushed
the
feature/internal-driver-system
branch
5 times, most recently
from
c157971 to
bed5e1e
Compare
alexandear
reviewed
Jul 9, 2025
cmd/limactl/disk.go
Outdated
| @@ -13,7 +13,7 @@ import ( | |||
| "text/tabwriter" | |||
|
|
|||
| contfs "github.com/containerd/continuity/fs" | |||
| "github.com/docker/go-units" | |||
| units "github.com/docker/go-units" | |||
There was a problem hiding this comment.
Is it necessary to change this line?
There was a problem hiding this comment.
I changed this to fix the lint issue, but it wasn’t causing it anyway!
pkg/driver/vz/vz_driver_darwin.go
Outdated
| info.DriverName = "vz" | ||
| info.VsockPort = l.vSockPort | ||
| info.VirtioPort = l.virtioPort | ||
| if l.Instance != nil && l.Instance.Dir != "" { |
There was a problem hiding this comment.
redundant check:
Suggested change
| if l.Instance != nil && l.Instance.Dir != "" { | |
| if l.Instance != nil { |
|
|
||
| func (l *LimaWslDriver) Info() driver.Info { | ||
| var info driver.Info | ||
| if l.Instance != nil && l.Instance.Dir != "" { |
There was a problem hiding this comment.
can be:
Suggested change
| if l.Instance != nil && l.Instance.Dir != "" { | |
| if l.Instance != nil { |
unsuman
force-pushed
the
feature/internal-driver-system
branch
2 times, most recently
from
a2dbce4 to
deaa857
Compare
unsuman
dismissed
AkihiroSuda’s stale review
The merge-base changed after approval.
|
Seems to need rebasing |
Signed-off-by: Ansuman Sahoo <[email protected]>
unsuman
force-pushed
the
feature/internal-driver-system
branch
from
deaa857 to
363baf5
Compare
AkihiroSuda
approved these changes
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a flexible, built-in plugin system for internal drivers. It leverages Go's blank import mechanism and build tags to allow for the conditional inclusion of drivers like QEMU and VZ directly into the
limactlbinary.Key Changes
init()function and blank import (_) pattern. Each internal driver now contains aregister.gofile that, when imported, automatically registers the driver with the central registry on program startup. This makes adding new built-in drivers a modular process.!external_qemu,!external_vz). This allows for creating customlimactlbuilds with or without specific drivers compiled in. This functionality lays the groundwork for the next PR, which will update theMakefileto support the use of these tags.driver.Driverinterface has been further broken down into smaller, more granular interfaces such asLifecycle,SnapshotManager, andGuestAgent. This refactoring improves code modularity and makes the requirements for implementing a new driver clearer.pkg/driverutil/instance.gohas been introduced to centralise driver creation logic. The newCreateDriverInstance()function looks up the appropriate driver in the registry and instantiates it.GSoC Project Context
This is the 3rd of 4 PRs in the initial GSoC project submission. It is dependent on the successful merge of the first two PRs #3691 and #3692 . After the prerequisite PRs are merged, this branch will be rebased to finalise the integration and prepare it for merging.
Related Issues